Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zy/38 rdflib navigation #40

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Zy/38 rdflib navigation #40

merged 10 commits into from
Jul 18, 2024

Conversation

zheyxu
Copy link
Collaborator

@zheyxu zheyxu commented Jul 10, 2024 •
edited
Loading

For issue #38

@zheyxu zheyxu requested a review from gjwgit July 10, 2024 09:48
@zheyxu zheyxu linked an issue Jul 10, 2024 that may be closed by this pull request
RDFLib: SPARQL to support navigation in Graph #38
Closed
4 tasks
@zheyxu zheyxu self-assigned this Jul 10, 2024
@zheyxu zheyxu mentioned this pull request Jul 10, 2024
Closed
4 tasks
@zheyxu zheyxu requested a review from anushkavidanage July 12, 2024 00:35
@gjwgit
Copy link
Contributor

gjwgit commented Jul 17, 2024

Thanks @anushkavidanage. Yes, we should only merge code that is required and cleanly implemented.

gjwgit
gjwgit approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending fixing re @anushkavidanage comment.

@gjwgit gjwgit requested a review from cdawei July 17, 2024 01:49
cdawei
cdawei reviewed Jul 17, 2024
View reviewed changes
lib/src/graph.dart Outdated Show resolved Hide resolved
lib/src/graph.dart Show resolved Hide resolved
@zheyxu zheyxu merged commit db9c6dc into main Jul 18, 2024
1 check passed
@zheyxu zheyxu deleted the zy/38_rdflib_navigation branch July 18, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anushkavidanage anushkavidanage anushkavidanage approved these changes

@cdawei cdawei cdawei approved these changes

@gjwgit gjwgit gjwgit approved these changes

Assignees

@zheyxu zheyxu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RDFLib: SPARQL to support navigation in Graph
4 participants
@zheyxu @gjwgit @cdawei @anushkavidanage